Use authType BASIC for Sabre client in integration tests#27421
Conversation
This helps massively reduce the numerous useless 401 exceptions that appears in the test log. These appear only because Sabre first connects without any auth type to receive the challenge and then sends the authentication data. With this change it will directly use basic auth.
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @IljaN, @SergioBertolinSG and @davitol to be potential reviewers. |
| public function downloadPublicFileWithRange($range){ | ||
| $token = $this->lastShareData->data->token; | ||
| $fullUrl = substr($this->baseUrl, 0, -4) . "public.php/webdav"; | ||
| $headers['Range'] = $range; |
There was a problem hiding this comment.
really removing the range?
| public function downloadPublicFileInsideAFolderWithRange($path, $range){ | ||
| $token = $this->lastShareData->data->token; | ||
| $fullUrl = substr($this->baseUrl, 0, -4) . "public.php/webdav" . "$path"; | ||
| $headers['Range'] = $range; |
There was a problem hiding this comment.
yes, my "IDE" told me it was unused when passing by so I removed it 😉
There was a problem hiding this comment.
There was a problem hiding this comment.
|
How can this one be back from the dead ? 😢 "sharing.Merging shares for recipient when shared from outside with group then user and recipient renames in between" |
|
I just restarted this one for you |
|
I had a quick look at the code with my fix from #26777 but can't understand why it still happens. Since the code doesn't explicitly compares the share ids, it might be that the share provider doesn't actually sort by id. Also the id of Maybe there's a way to fix the test to add a delay between share creation. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
4 participants
This helps massively reduce the numerous useless 401 exceptions that
appears in the test log. These appear only because Sabre first connects
without any auth type to receive the challenge and then sends the
authentication data.
With this change it will directly use basic auth.
Thanks to @butonic for hinting at this here https://github.com/owncloud/core/pull/27216/files#diff-5c2150d9ba844c7e57f5de66708c7d78R72
Please review @owncloud/qa @DeepDiver1975
I suggest backporting this, it makes logs from integration tests more readable.